postgres: switch to query_typed api to avoid prepared statement overhead #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #5032 will not alter performanceComparing Summary
|
tmm1
force-pushed
the
rust-postgres-query-typed
branch
from
1cb4c45 to
db8a787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements the new
query_typedapi from sfackler/rust-postgres#1147this will remove extra round-trips to the database to create prepared statements.
these roundtrips are especially apparent when statement caching is unavailable, such as when using pgbouncer.
statement cache was also ineffective when using traceparent tracing, because sql comments are part of the statement cache key.
follow up to #5027
fixes #5025 #5017
cc @aqrln