Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Sum & Prod trait impls for Expression #205

Closed
CPerezz opened this issue Sep 15, 2023 · 2 comments · Fixed by #209
Closed

Implement Sum & Prod trait impls for Expression #205

CPerezz opened this issue Sep 15, 2023 · 2 comments · Fixed by #209
Assignees
@pnyda

Comments

@CPerezz
Copy link
Member

CPerezz commented Sep 15, 2023

There are some times where we do need to sum a bunch of Expressions in a Vec. When this happens, we're forced to use fold() instead of just using sum() which would lead to less boilerplate.

Would be nice to have that implemented.
@pnyda
Copy link

pnyda commented Sep 18, 2023

wanna work on this!

@CPerezz
Copy link
Member Author

CPerezz commented Sep 18, 2023

@chokermaxx assigned to you!

@pnyda pnyda mentioned this issue Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnyda pnyda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Sum and Product for Expression pnyda/halo2
2 participants
@CPerezz @pnyda