Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing to nested [k1 k2] should store as {k1 {k2 ...}} #53

Open
sritchie opened this issue Nov 14, 2023 · 0 comments
Open

tracing to nested [k1 k2] should store as {k1 {k2 ...}} #53

sritchie opened this issue Nov 14, 2023 · 0 comments
Labels

Comments

@sritchie
Copy link
Collaborator

From discussions with Alex, I realized that our current strategy of storing these sequential keys as {[k1 k2] ...} is incorrect. The reason is that we want to be able to generate proposals for nested sequences of choicemaps without having to copy the whole nested structure in our proposal generators.

So tracing to k2 internal to a trace to k1 should result in the same stored values as tracing to [k1 k2].

And if you do the latter, you should NOT be able to do the former afterward (since the k1 address is already taken). This is a touch subtle, because traces to [k1 k2], [k1 k3] etc at the same level need to succeed, even though k1 is already written to at when [k1 k3] comes along.

@sritchie sritchie added the fix label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant