Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add let-traced #7

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add let-traced #7

wants to merge 1 commit into from

Conversation

zane
Copy link
Collaborator

@zane zane commented Apr 6, 2023

No description provided.

@zane zane added the feat label Apr 6, 2023
@zane zane self-assigned this Apr 6, 2023
@zane zane force-pushed the zane/let-traced branch 2 times, most recently from 3cb3d56 to 556dcc1 Compare April 25, 2023 23:05
@sritchie sritchie force-pushed the zane/let-traced branch 2 times, most recently from 8892c5f to 87d96eb Compare October 2, 2023 17:50
@sritchie
Copy link
Collaborator

sritchie commented Oct 2, 2023

I don't think this will work with our current gen-rewrites-trace!-calls approach. More evidence for a function-based approach being the right way?

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #7 (a52e369) into main (58486bd) will decrease coverage by 0.47%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   66.76%   66.29%   -0.47%     
==========================================
  Files          18       18              
  Lines         707      715       +8     
  Branches       17       16       -1     
==========================================
+ Hits          472      474       +2     
- Misses        218      225       +7     
+ Partials       17       16       -1     
Files Coverage Δ
src/gen/dynamic.cljc 43.13% <12.50%> (-2.61%) ⬇️

... and 1 file with indirect coverage changes

@zane
Copy link
Collaborator Author

zane commented Oct 9, 2023

Yes, though we could probably unblock this in the interim by having the gen macro macroexpand its argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants