Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generative functions returned by map and unfold and recurse are not callable. #78

Closed
marcoct opened this issue Feb 21, 2019 · 3 comments
Closed

Generative functions returned by map and unfold and recurse are not callable. #78

marcoct opened this issue Feb 21, 2019 · 3 comments
Labels
good first issue Good for newcomers Priority

Comments

@marcoct
Copy link
Collaborator

marcoct commented Feb 21, 2019

All generative functions should be callable.
@marcoct marcoct changed the title Map is not callable The generative functions returned by map and unfold and recurse are not callable. Feb 21, 2019
@marcoct marcoct changed the title The generative functions returned by map and unfold and recurse are not callable. Generative functions returned by map and unfold and recurse are not callable. Feb 21, 2019
@marcoct
Copy link
Collaborator Author

marcoct commented Feb 21, 2019 •
edited
Loading

For reference, this is how DynamicDSL generative functions are made callable:
https://github.com/probcomp/Gen/blob/master/src/dynamic/dynamic.jl#L33-L36

@marcoct marcoct added good first issue Good for newcomers Priority labels Feb 21, 2019
@marcoct
Copy link
Collaborator Author

marcoct commented Feb 21, 2019 •
edited
Loading

Note that this cannot currently be implemented generically for all generative functions, because GenerativeFunction is an abstract type: JuliaLang/julia#14919

@marcoct
Copy link
Collaborator Author

marcoct commented Mar 1, 2019

Fixed in probcomp/GenExperimental.jl@1e44b31

@marcoct marcoct closed this as completed Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcoct