Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move to ESM #841

Merged
merged 6 commits into from
Mar 12, 2024
Merged

feat: Move to ESM #841

merged 6 commits into from
Mar 12, 2024

Conversation

AaronDewes
Copy link
Member

The goal here is to move all examples to ESM.

@AaronDewes AaronDewes self-assigned this Mar 6, 2024
@AaronDewes
Copy link
Member Author

@Uzlopak @gr2m are you okay with the examples using Node's test runner or should I use vitest/jest?

This was referenced Mar 8, 2024
Open
Closed
@AaronDewes AaronDewes marked this pull request as ready for review March 8, 2024 20:36
AaronDewes and others added 2 commits March 8, 2024 23:21
@AaronDewes @wolfy1339
Update templates/basic-ts/tsconfig.json
eb6bd5d 
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
@AaronDewes
Fix duplication
d33974a
@gr2m
Copy link
Contributor

gr2m commented Mar 11, 2024

@Uzlopak @gr2m are you okay with the examples using Node's test runner or should I use vitest/jest?

I prefer Node's test runner. I would avoid jest.

gr2m
gr2m approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me 👍🏼

@AaronDewes AaronDewes changed the title feat!: Move to ESM feat: Move to ESM Mar 12, 2024
@AaronDewes AaronDewes merged commit 455fd80 into master Mar 12, 2024
5 checks passed
@AaronDewes AaronDewes deleted the esm branch March 12, 2024 08:02
@AaronDewes AaronDewes mentioned this pull request Mar 12, 2024
Closed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 wolfy1339 left review comments

@gr2m gr2m gr2m approved these changes

@Uzlopak Uzlopak Awaiting requested review from Uzlopak

Assignees

@AaronDewes AaronDewes

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronDewes @gr2m @wolfy1339