-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: modernize code and remove dependencies #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the breaking changes? Drop support for Node < 18 and use of native fetch?
exactly |
Can I get permissions please? I could then close some issues and pull requests, when this gets released. |
@gr2m |
we don't have an automated release setup yet, let me take care of this |
🎉 This PR is included in version 1.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
well ouch that should have been v2.0.0 not sure why it didn't recognize the
I'm looking into it |
🎉 This PR is included in version 1.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lol now the revert failed to build: https://github.com/probot/smee-client/actions/runs/6909425601/job/18800742387 so I cannot release 1.2.5 🤷🏼 For now I've set 1.2.3 as |
@Uzlopak do these type errors look familiar? Maybe they are easy to fix in the 1.x branch?
|
I might have found a way |
All set. |
This PR refactors the whole codebase. Removes unecessary deps, use of built in fetch.
Should be released as semver-major.
I was first confused, because it seemed, that it was bugged, because the payload of the endpoint was not returned. Then I tested it with the original smee-client and realized that it is a one way thing... smee.io does not return the answer of the webserver. Please correct me if I am wrong.
Coverage is improved significantly.
BREAKING CHANGE: drop support for Node <18
BREAKING CHANGE: use native
fetch
for requests