Skip to content
This repository has been archived by the owner on Feb 28, 2021. It is now read-only.

rename some args #135

Open
1 task done
mithru opened this issue Sep 30, 2018 · 1 comment
Open
1 task done

rename some args #135

mithru opened this issue Sep 30, 2018 · 1 comment

Comments

@mithru
Copy link
Collaborator

mithru commented Sep 30, 2018

Nature of issue

  • Existing feature enhancement

I realized things like the below line from fillEntity.js use the name shapeObject which perhaps makes sense in shapeEntity.js but the meaning doesn't carry through for newer methods. Maybe we can rename it to methodObject ? I sure helps me understand the code a lot better.

function FillEntity(Interceptor, shapeObject, fillArgs, canvasX, canvasY) 

For reference, if I console.log(shapeObject) I get this

{name: "fill", params: Array(4), class: "p5", module: "Color", submodule: "Setting"}

Thoughts?

@mithru
Copy link
Collaborator Author

mithru commented Sep 30, 2018

I can do this, if we decide to make this change. Regardless, I'm using methodObject on newer entities that I implement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant