Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative dimensions will mirror rect() again #7363

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Negative dimensions will mirror rect() again #7363

wants to merge 3 commits into from

Conversation

martinleopold
Copy link
Contributor

Resolves #7353

Changes:

Fix a regression with negative values for width and/or height on rect(), ellipse(), and arc()

Screenshots of the change:

N/A

PR Checklist

@martinleopold
Negative dimensions will flip shapes again
75fac2e 
Only applicable to shape mode `CORNER`
Fixes processing#7353
@martinleopold
Copy link
Contributor Author

This resolves the immediate issue by adjusting the position of the shape when using negative dimensions.
I'm wondering if we need to look into what happens with textured shapes. In this case the texture should actually be flipped i.e. properly mirrored, I guess?

@perminder-17 perminder-17 self-requested a review November 7, 2024 02:13
perminder-17
perminder-17 suggested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@perminder-17 perminder-17 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your hard work on this! I truly appreciate the effort you've put in. There is one potential issue I wanted to mention regarding texture image handling. While you’ve done a great job adjusting the positioning in CORNERS, CORNER, etc., it seems that the image itself isn’t being flipped when necessary—only the position is being shifted. Adding a flip where needed could enhance the solution. Please let us know if there’s any way we can assist in exploring or addressing this aspect.

Expected:

image

Your's:

image

@martinleopold
Copy link
Contributor Author

@perminder-17 Thanks for pointing that out, will look into it.

@martinleopold
Copy link
Contributor Author

martinleopold commented Nov 15, 2024 •
edited
Loading

@perminder-17 I think my latest commit should restore the original behavior. This means that rect() will mirror, while ellipse() and arc() will NOT.

@martinleopold martinleopold changed the title Negative dimensions will flip shapes again Negative dimensions will mirror rect() again Nov 15, 2024
@martinleopold
Mirrored rendering for negative dimensions with rect().
ebd00c2 
ellipse() and arc() use absolute values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perminder-17 perminder-17 perminder-17 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@martinleopold @perminder-17