Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for handling Java “modules” and clean up JavaFX-specific workarounds #212

Open
processing-bot opened this issue Jun 21, 2021 · 0 comments

Comments

@processing-bot
Copy link
Collaborator

Created by: benfry

JavaFX 16 (which we're using as of 4.0 alpha 5) is bundled as a set of Java “modules,” rather than regular .jar files. As such, it will complain if the code is loaded from the usual CLASSPATH.

For now, there are some workarounds in the build process that treat the (newly separated) JavaFX library as a special case, but this is pretty gross, and we need to either:

  1. Start tracking a modulesPath and module lists during build and bundling so that it can be specified when running from the PDE and when exporting.
  2. Alternatively, we could add additional information to library.properties so that special command line options can be added. In this case, it would be --add-modules javax.base, etc, but could also be used to cover -XstartOnFirstThread for libraries that require that (LWJGL?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant