You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first one looks like it's using and old substring() call to clean up the name of the downloaded JDK… It should be something like jdk-11.04.tgz or whatever the syntax is nowadays.
For the second, do we need this temp folder kept around? In the past we built the app and then have the JDK embedded there… second copy in the repo is another 200 MB (plus another 100MB for JavaFX).
Same goes with naming for JFX bits… Something like javafx-11.0.2.zip should work, and if we need the folder there, keeping the same name.
The text was updated successfully, but these errors were encountered:
Created by: benfry
The current build creates two files not covered by
.gitignore
that we should sort out.The first one looks like it's using and old
substring()
call to clean up the name of the downloaded JDK… It should be something likejdk-11.04.tgz
or whatever the syntax is nowadays.For the second, do we need this temp folder kept around? In the past we built the app and then have the JDK embedded there… second copy in the repo is another 200 MB (plus another 100MB for JavaFX).
Same goes with naming for JFX bits… Something like
javafx-11.0.2.zip
should work, and if we need the folder there, keeping the same name.The text was updated successfully, but these errors were encountered: