Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning up build/macosx/jdk-0u1.tgz and build/macosx/jdk-11.0.1+13/ #6

Closed
processing-bot opened this issue Oct 8, 2019 · 3 comments

Comments

@processing-bot
Copy link
Collaborator

Created by: benfry

The current build creates two files not covered by .gitignore that we should sort out.

build/macosx/jdk-0u1.tgz
build/macosx/jdk-11.0.1+13/

The first one looks like it's using and old substring() call to clean up the name of the downloaded JDK… It should be something like jdk-11.04.tgz or whatever the syntax is nowadays.

For the second, do we need this temp folder kept around? In the past we built the app and then have the JDK embedded there… second copy in the repo is another 200 MB (plus another 100MB for JavaFX).

Same goes with naming for JFX bits… Something like javafx-11.0.2.zip should work, and if we need the folder there, keeping the same name.

@processing-bot
Copy link
Collaborator Author

Created by: sampottinger

Hey @benfry! I attempted to resolve this with #12. Can I close this issue or is there more you want to tackle? Thanks!

@processing-bot
Copy link
Collaborator Author

Created by: benfry

All set; thanks.

@processing-bot
Copy link
Collaborator Author

Created by: github-actions[bot]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant