Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info on order of chai plugins #32

Open
dietergeerts opened this issue Dec 22, 2017 · 1 comment
Open

Info on order of chai plugins #32

dietergeerts opened this issue Dec 22, 2017 · 1 comment
Labels

Comments

@dietergeerts
Copy link

In the readme, this package states that other plugins have to be added after this one, in order to have their property assertions be converted to methods BUT chai-as-promise have to be added first. Now the chai-as-promise package state that other plugins have to added BEFORE itself in order to use them with .eventually. This means that we have to choose if we want other plugins be usable with as-promise or convert their properties to methods. I would want to do both.

I tried adding dirty-chai as the last plugin, and it still works, so has the above been changed and the readme not updated? Or am I missing something?

@joshperry joshperry added the docs label Mar 12, 2018
@joshperry
Copy link
Contributor

Hi @dietergeerts,

Yeah, this is a bit confusing. Some changes have been made to the library in order to relax the inclusion order sensitivity, and the readme was never updated accordingly. I'll see if I can put some work into testing with some other popular plugins and update the documentation to be more accurate as to any hard ordering requirements.

Thanks for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants