You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Caveat: ./github/action/build-component-per-arch/main.js runs (bash) find in containers, assuming (which it shouldn't), that containers' (plural) entrypoint is a shell and that it's able to override some default command:
A better practice (per the above) is for the container's primary function e.g. agent, controller etc. to be its entrypoint. Then, running containers is like running any other binary.
NOTE It's also preferable to not include superfluous functionality (e.g. bash) in a container whose function doesn't require bash; security, patching reasons etc.
Alternatives in this case:
Run the container and docker cp ${ID}:/path/to/known/location/container-images-legal-notice.md /somewhere/on/host
Retain bash or some other shell but make this a requirement for Akri developers so that you can --entrypoint=/bin/bash
Require container developers to host a small httpd that responds on any path by returning the legal notice
Our containers use CMD rather than ENTRYPOINT, but it seems that best practice is to use ENTRYPOINT:
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#entrypoint
We should change our dockerfiles according to best practices.
The text was updated successfully, but these errors were encountered: