Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Test cases needs to be moved from Python Testing Suite - No commissioning to Python Testing Suite #410

Closed
KishokG opened this issue Sep 9, 2024 · 5 comments
Assignees
Labels

Comments

@KishokG
Copy link

KishokG commented Sep 9, 2024

Describe the bug

Below mentioned tescases are listed under the Python Testing Suite - No commissioning in the TH UI. But this tescase needs to be commissioned before the test execution hence this testcase needs to be moved to the Python Testing Suite.

  • TC-DEM-2.2
  • TC-DEM-2.3
  • TC-DEM-2.4
  • TC-DEM-2.5
  • TC-DEM-2.6
  • TC-DEM-2.7
  • TC-DEM-2.8
  • TC-DEM-2.9
  • TC-DEM-2.10
  • TC-EEVSE-2.2
  • TC-EEVSE-2.3
  • TC-EEVSE-2.4
  • TC-EEVSE-2.5
  • TC-EEVSE-2.6
  • TC-EWATERHTR-2.1
  • TC-EWATERHTR-2.2
  • TC-EWATERHTR-2.3

Steps to reproduce the behavior

  1. From the Test-Harness user interface loaded the PICS file to select the test cases.
  2. Selected the python test case in Python Testing Suite - No commissioning section to executed.
  3. Click the Start button on Test-Harness user interface.

Expected behavior

The testcase needs to be commissioned before the start python test.

Log files

UI_Test_Run_2024_09_09_16_24_55.log

PICS file

PICS.zip

Screenshots

image

Environment

Version: v2.11-beta3+fall2024
Sha: f52d40a

Additional Information

No response

@KishokG KishokG added Bug Something isn't working Needs Triage labels Sep 9, 2024
@fabiowmm
Copy link
Contributor

fabiowmm commented Sep 9, 2024

This is a script issue. Test scripts need to follow the example in connectedhomeip/src/python_testing/hello_test.py. Take a look at the comments in the test_TC_NAMES_2_1 method. It's just a matter of setting the is_commissioning variable.

@jamesharrow
Copy link

I've created an SDK PR with this change in - project-chip/connectedhomeip#35560

Please review

@jamesharrow
Copy link

The PR for SDK has now merged which includes the is_commissioning=True
project-chip/connectedhomeip#35560

@rquidute
Copy link
Contributor

Hi @jamesharrow The SDK SHA 17b1a38e909e7874593bcb87c31be03a5866f1d4 is the one picked for SVE, so if you want to verify the changes, you can validate by side loading the modified version.

@KishokG
Copy link
Author

KishokG commented Oct 3, 2024

Issue fixed

@KishokG KishokG closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants