From df499648ab7c3323bd342c52e83811c65ecde58a Mon Sep 17 00:00:00 2001 From: "tennessee.carmelveilleux@gmail.com" Date: Fri, 14 Jun 2024 15:38:52 -0400 Subject: [PATCH] Add warning about GetDiscriminator --- src/protocols/secure_channel/RendezvousParameters.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/protocols/secure_channel/RendezvousParameters.h b/src/protocols/secure_channel/RendezvousParameters.h index c7a90f4127383e..80f537e3b8da6b 100644 --- a/src/protocols/secure_channel/RendezvousParameters.h +++ b/src/protocols/secure_channel/RendezvousParameters.h @@ -62,6 +62,10 @@ class RendezvousParameters // discriminators. bool HasDiscriminator() const { return mHasDiscriminator; } + // Obtains the long version of the discriminator, or 0 if short. + // WARNING: This is lossy and a bad idea to use. The correct method to use + // is GetSetupDiscriminator(). This method exists for public + // API backwards compatibility. uint16_t GetDiscriminator() const { if (mSetupDiscriminator.IsShortDiscriminator())