Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assess the correct use of ConcreteReadAttributePath in the read call-path for the IM #12049

Closed
mrjerryjohns opened this issue Nov 19, 2021 · 7 comments
Assignees

Comments

@mrjerryjohns
Copy link
Contributor

This PR introduces a ConcreteReadAttributePath that contains a list index. However, it adds the use of that fairly late in the call chain for handling a read (inside the ReadSingleClusterData function). We should assess where the right place for this to be is.

@mrjerryjohns
Copy link
Contributor Author

Assigning this to you @erjiaqing since you're gonna be in this space a fair bit.

@bzbarsky-apple
Copy link
Contributor

Fwiw, I think ReadSingleClusterData should definitely take a ConcreteReadAttributePath.

@bzbarsky-apple
Copy link
Contributor

#12067 fixes the obvious thing. Need to figure out how to share the path-expanding iterator between read and write paths before we can push things further.

@holbrookt
Copy link
Contributor

@bzbarsky-apple @mrjerryjohns is this needed for 1.0? If not, please remove the label. Thanks!

@bzbarsky-apple
Copy link
Contributor

I don't think the remaining work here is a 1.0 blocker, personally.

@stale
Copy link

stale bot commented Aug 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Aug 12, 2022
@mrjerryjohns
Copy link
Contributor Author

Already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants