Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialReport for readClient when involving chunk scenario during post-subscription. #12128

Closed
yunhanw-google opened this issue Nov 23, 2021 · 1 comment
Assignees

Comments

@yunhanw-google
Copy link
Contributor

this seems to be problematic, currently mInitialReport in readClient is set to true in init and shutdown, then after receiving the initial priming report, it is set to false. During subscription, for every beginning report and end report, it needs to call OnReportBegin and OnReportEnd, then recover the mInitialReport to true for next round...

before this PR, IsInitialReport() is used to get the subscriptionid, I suggest to have IsPrimingReport for this purpose, then make isInitialReport for chunking report begin purpose.

Originally posted by @yunhanw-google in #12071 (comment)

@yunhanw-google
Copy link
Contributor Author

#12443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants