You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
this seems to be problematic, currently mInitialReport in readClient is set to true in init and shutdown, then after receiving the initial priming report, it is set to false. During subscription, for every beginning report and end report, it needs to call OnReportBegin and OnReportEnd, then recover the mInitialReport to true for next round...
before this PR, IsInitialReport() is used to get the subscriptionid, I suggest to have IsPrimingReport for this purpose, then make isInitialReport for chunking report begin purpose.
this seems to be problematic, currently mInitialReport in readClient is set to true in init and shutdown, then after receiving the initial priming report, it is set to false. During subscription, for every beginning report and end report, it needs to call OnReportBegin and OnReportEnd, then recover the mInitialReport to true for next round...
before this PR, IsInitialReport() is used to get the subscriptionid, I suggest to have IsPrimingReport for this purpose, then make isInitialReport for chunking report begin purpose.
Originally posted by @yunhanw-google in #12071 (comment)
The text was updated successfully, but these errors were encountered: