You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In MTRBaseClusters.h, see if we can generate any sort of basic documentation for the interfaces and/or their methods.
In MTRBaseClusters.h, see if we can have "ACL" instead of "Acl" in things like readAttributeAclWithParams. The problem, I suspect, is that asUpperCamelCase does the latter, so we may need a different helper or something, and at this point a different helper needs the overhead of a trip through the ZAP repo.
In MTRClusterConstants.h, see if we can have "ClusterOTA" not "ClusterOta" (similar to the ACL issue above.
Make sure the prefixes on the enum names match the type. So instead of MTRClusterIdentifyID have MTRClusterIDTypeIdentifyID and so on.
Think about the naming of the enum values for MTRClusterAttributeIDType and rename it to MTRAttributeIdType. Perhaps something like:
Reproduction steps
readAttributeAclWithParams
. The problem, I suspect, is thatasUpperCamelCase
does the latter, so we may need a different helper or something, and at this point a different helper needs the overhead of a trip through the ZAP repo.MTRClusterIdentifyID
haveMTRClusterIDTypeIdentifyID
and so on.MTRClusterAttributeIDType
and rename it toMTRAttributeIdType
. Perhaps something like:MTRCommandIDType
:Part of #22420 and independent of the other work going on in that issue.
Platform
darwin
Platform Version(s)
No response
Type
Manually tested with SDK
(Optional) If manually tested please explain why this is only manually tested
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: