Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Logging APIs Could Try to Log Nullptr While Logging Strings #23603

Closed
emargolis opened this issue Nov 15, 2022 · 0 comments · Fixed by #23604
Closed

[1.0] Logging APIs Could Try to Log Nullptr While Logging Strings #23603

emargolis opened this issue Nov 15, 2022 · 0 comments · Fixed by #23604
Assignees
@emargolis

Comments

@emargolis
Copy link
Contributor

Reproduction steps

Some %s specifiers in the logging APIs (ChipLogError(), ChipLogProgress(), ChipLogDetail()) don't have a guaranteed non-null string.

Need to identify those potential cases where %s parameter might be null-ptr and use StringOrNullMarker() helper method to guarantee it doesn't happen.

Bug prevalence

100% of the time

GitHub hash of the SDK that was being used

9a41c9c

Platform

core

Platform Version(s)

1.0.0

Type

Core SDK Crash

Anything else?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emargolis emargolis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Logging When Trying to Log Nullptr To Strings emargolis/connectedhomeip-1
1 participant
@emargolis