Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align DescriptorCluster and SemanticTagStruct with the spec draft #27556

Closed
robszewczyk opened this issue Jun 29, 2023 · 1 comment · Fixed by #28753
Closed

Align DescriptorCluster and SemanticTagStruct with the spec draft #27556

robszewczyk opened this issue Jun 29, 2023 · 1 comment · Fixed by #28753
Labels
cert blocker cluster xml for 1.2 Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Milestone
1.2

Comments

@robszewczyk
Copy link
Contributor

robszewczyk commented Jun 29, 2023 •
edited
Loading

The latest changes move the Label field from TagStruct to SemanticLabelStruct. As a result:

  • TagList attribute in the Descriptor cluster changes types to list[SemanticLabelStruct]
  • SemanticLabelStruct contains the following fields:
ID Name Type
0 MfgCode vendor-id
1 Namespace namespace
2 Tag tag
3 Label string
@robszewczyk robszewczyk added v1.2 Spec XML align SDK XML does not match the spec (including naming, etc) cluster xml for 1.2 labels Jun 29, 2023
@bzbarsky-apple bzbarsky-apple added the spec Mismatch between spec and implementation label Jul 6, 2023
@github-project-automation github-project-automation bot moved this to Open Cert Blockers in [Certification] Blockers Aug 9, 2023
@cjandhyala cjandhyala added this to the 1.2 milestone Aug 10, 2023
@mideayanghui mideayanghui mentioned this issue Aug 26, 2023
Merged
@jadhavrohit924
Copy link
Contributor

Fixed with #27905 and #28753

@github-project-automation github-project-automation bot moved this from Open Cert Blockers to Complete in [Certification] Blockers Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cert blocker cluster xml for 1.2 Spec XML align SDK XML does not match the spec (including naming, etc) spec Mismatch between spec and implementation v1.2
Projects
[Certification] Blockers
Archived in project
[Enhancements] Spec/XML Alignment
Archived in project
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Add functions to set TagList attribute in descriptor cluster mideayanghui/connectedhomeip
4 participants
@robszewczyk @bzbarsky-apple @cjandhyala @jadhavrohit924