You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just to reiterate: if err is not CHIP_NO_ERROR at this point then the value of onSuccessCallback is generally speaking garbage we should not be examining it at all. Same for onFailureCallback. Nothing in the callbacks API definition guarantees that it will leave the values untouched on error, or set to anything in particular on error.
So if we got an error here, we are in fact "missing" both callbacks and the filter, as far as we're concerned. Or in other words, we should just log that the GetResponseCallback call failed and not try to log any details about the state of the callback manager, because we don't know those details here.
Just to reiterate: if
err
is notCHIP_NO_ERROR
at this point then the value ofonSuccessCallback
is generally speaking garbage we should not be examining it at all. Same foronFailureCallback
. Nothing in the callbacks API definition guarantees that it will leave the values untouched on error, or set to anything in particular on error.So if we got an error here, we are in fact "missing" both callbacks and the filter, as far as we're concerned. Or in other words, we should just log that the
GetResponseCallback
call failed and not try to log any details about the state of the callback manager, because we don't know those details here.Originally posted by @bzbarsky-apple in #7634 (comment)
The text was updated successfully, but these errors were encountered: