Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESP32] Fix template argument for scan response #29437

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[ESP32] Fix template argument for scan response #29437

merged 1 commit into from
Sep 25, 2023

Conversation

jadhavrohit924
Copy link
Contributor

Problem

  • chip::Optional should have template argument.

@github-actions
Copy link

github-actions bot commented Sep 25, 2023 •
edited
Loading

PR #29437: Size comparison from 33052cc to 0cc1eab

Increases (1 build for telink)
platform target config section 33052cc 0cc1eab change % change
telink ota-requestor-app tlsr9518adk80d (read/write) 956444 956452 8 0.0
text 671956 671960 4 0.0
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 33052cc 0cc1eab change % change
bl602 lighting-app bl602 (read/write) 1380378 1380378 0 0.0
.bss 77742 77742 0 0.0
.data 9368 9368 0 0.0
.text 1067014 1067014 0 0.0
bl602+rpc (read/write) 1427590 1427590 0 0.0
.bss 85766 85766 0 0.0
.data 9728 9728 0 0.0
.text 1098788 1098788 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1177523 1177523 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 30865 30865 0 0.0
.bss_psram 57552 57552 0 0.0
.comment 48 48 0 0.0
.data 3568 3568 0 0.0
.debug_abbrev 1544168 1544168 0 0.0
.debug_aranges 138400 138400 0 0.0
.debug_frame 508088 508088 0 0.0
.debug_info 41902048 41902048 0 0.0
.debug_line 5426963 5426963 0 0.0
.debug_loc 3523254 3523254 0 0.0
.debug_ranges 376832 376832 0 0.0
.debug_str 3965780 3965780 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106796 106796 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 596713 596713 0 0.0
.symtab 177216 177216 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
961034 961034 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276075 1276075 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 39333 39333 0 0.0
.bss_psram 57536 57536 0 0.0
.comment 48 48 0 0.0
.data 4088 4088 0 0.0
.debug_abbrev 1725082 1725082 0 0.0
.debug_aranges 147120 147120 0 0.0
.debug_frame 537432 537432 0 0.0
.debug_info 47051809 47051809 0 0.0
.debug_line 5845040 5845040 0 0.0
.debug_loc 3730239 3730239 0 0.0
.debug_ranges 404384 404384 0 0.0
.debug_str 4393849 4393849 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121860 121860 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 661454 661454 0 0.0
.symtab 196544 196544 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1035022 1035022 0 0.0
bl706-eth (read/write) 1035184 1035184 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 29978 29978 0 0.0
.bss_psram 97783 97783 0 0.0
.comment 48 48 0 0.0
.data 3248 3248 0 0.0
.debug_abbrev 1079092 1079092 0 0.0
.debug_aranges 115408 115408 0 0.0
.debug_frame 427500 427500 0 0.0
.debug_info 22656522 22656522 0 0.0
.debug_line 4359718 4359718 0 0.0
.debug_loc 3032652 3032652 0 0.0
.debug_ranges 312712 312712 0 0.0
.debug_str 3545086 3545086 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 152 152 0 0.0
.psram 9 9 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 96496 96496 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 464997 464997 0 0.0
.symtab 139888 139888 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
787326 787326 0 0.0
bl706-wifi (read only) 3870 3870 0 0.0
(read/write) 1198571 1198571 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 14569 14569 0 0.0
.bss_psram 98551 98551 0 0.0
.comment 48 48 0 0.0
.data 3560 3560 0 0.0
.debug_abbrev 1172553 1172553 0 0.0
.debug_aranges 119584 119584 0 0.0
.debug_frame 620052 620052 0 0.0
.debug_info 23828352 23828352 0 0.0
.debug_line 4604487 4604487 0 0.0
.debug_loc 3132465 3132465 0 0.0
.debug_ranges 322528 322528 0 0.0
.debug_str 3617377 3617377 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.psram 9 9 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109624 109624 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 505724 505724 0 0.0
.symtab 152752 152752 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3870 3870 0 0.0
.text 0 0 0 0.0
954118 954118 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1157260 1157260 0 0.0
.boot2 292 292 0 0.0
.bss 20324 20324 0 0.0
.bss_psram 77216 77216 0 0.0
.comment 48 48 0 0.0
.data 4512 4512 0 0.0
.debug_abbrev 1538701 1538701 0 0.0
.debug_aranges 133264 133264 0 0.0
.debug_frame 488732 488732 0 0.0
.debug_info 41369495 41369495 0 0.0
.debug_line 5330513 5330513 0 0.0
.debug_loc 3467529 3467529 0 0.0
.debug_ranges 383368 383368 0 0.0
.debug_str 3990490 3990490 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100784 100784 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 598390 598390 0 0.0
.symtab 176688 176688 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
943878 943878 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 737923 737923 0 0.0
(read/write) 166444 166444 0 0.0
.bss 88860 88860 0 0.0
.data 3420 3420 0 0.0
.rodata 84383 84383 0 0.0
.text 653148 653148 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 758155 758155 0 0.0
(read/write) 176700 176700 0 0.0
.bss 99084 99084 0 0.0
.data 3436 3436 0 0.0
.rodata 80087 80087 0 0.0
.text 677680 677680 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 745715 745715 0 0.0
(read/write) 171172 171172 0 0.0
.bss 93556 93556 0 0.0
.data 3436 3436 0 0.0
.rodata 106111 106111 0 0.0
.text 639216 639216 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 696107 696107 0 0.0
(read/write) 165536 165536 0 0.0
.bss 87728 87728 0 0.0
.data 3408 3408 0 0.0
.rodata 80271 80271 0 0.0
.text 615444 615444 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 681691 681691 0 0.0
(read/write) 165676 165676 0 0.0
.bss 87872 87872 0 0.0
.data 3404 3404 0 0.0
.rodata 76103 76103 0 0.0
.text 605196 605196 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 619522 619522 0 0.0
(read/write) 206900 206900 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200344 200344 0 0.0
.comment 206 206 0 0.0
.data 1436 1436 0 0.0
.debug_abbrev 931803 931803 0 0.0
.debug_aranges 107496 107496 0 0.0
.debug_frame 363368 363368 0 0.0
.debug_info 20866486 20866486 0 0.0
.debug_line 2773001 2773001 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1573529 1573529 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 101428 101428 0 0.0
.debug_str 3386959 3386959 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106290 106290 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 511040 511040 0 0.0
.symtab 296912 296912 0 0.0
.text 511112 511112 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 555191 555191 0 0.0
.app_xip_area 446385 446385 0 0.0
.bss 63776 63776 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 540087 540087 0 0.0
.app_xip_area 426489 426489 0 0.0
.bss 68544 68544 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 575223 575223 0 0.0
.app_xip_area 467753 467753 0 0.0
.bss 62512 62512 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 559135 559135 0 0.0
.app_xip_area 448569 448569 0 0.0
.bss 65512 65512 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1008892 1008892 0 0.0
.bss 170804 170804 0 0.0
.data 2668 2668 0 0.0
.text 835396 835396 0 0.0
BRD4187C (read/write) 1090684 1090684 0 0.0
.bss 194912 194912 0 0.0
.data 3256 3256 0 0.0
.text 892496 892496 0 0.0
lock-app BRD4161A+wf200 (read/write) 1104088 1104088 0 0.0
.bss 185484 185484 0 0.0
.data 2680 2680 0 0.0
.text 915904 915904 0 0.0
window-app BRD4187C (read/write) 1124584 1124584 0 0.0
.bss 167352 167352 0 0.0
.data 3128 3128 0 0.0
.text 954084 954084 0 0.0
esp32 all-clusters-app c3devkit (read only) 1177426 1177426 0 0.0
(read/write) 1702372 1702372 0 0.0
.dram0.bss 77640 77640 0 0.0
.dram0.data 13060 13060 0 0.0
.flash.rodata 268744 268744 0 0.0
.flash.text 1177426 1177426 0 0.0
.iram0.text 75244 75244 0 0.0
m5stack (read only) 1218839 1218839 0 0.0
(read/write) 552066 552066 0 0.0
.dram0.bss 84288 84288 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 300140 300140 0 0.0
.flash.text 1213455 1213455 0 0.0
.iram0.text 123287 123287 0 0.0
k32w contact k32w0+release (read only) 590444 590444 0 0.0
(read/write) 87508 87508 0 0.0
.bss 70760 70760 0 0.0
.data 2124 2124 0 0.0
.text 589908 589908 0 0.0
light k32w0+release (read only) 590236 590236 0 0.0
(read/write) 87184 87184 0 0.0
.bss 70448 70448 0 0.0
.data 2112 2112 0 0.0
.text 589700 589700 0 0.0
lock k32w0+release (read only) 561516 561516 0 0.0
(read/write) 85016 85016 0 0.0
.bss 68336 68336 0 0.0
.data 2056 2056 0 0.0
.text 560980 560980 0 0.0
linux all-clusters-app debug (read only) 5655521 5655521 0 0.0
(read/write) 420984 420984 0 0.0
.bss 130448 130448 0 0.0
.data 3840 3840 0 0.0
.data.rel.ro 279328 279328 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1344 1344 0 0.0
.rodata 336876 336876 0 0.0
.text 4936579 4936579 0 0.0
all-clusters-minimal-app debug (read only) 4928841 4928841 0 0.0
(read/write) 232624 232624 0 0.0
.bss 126480 126480 0 0.0
.data 3744 3744 0 0.0
.data.rel.ro 95280 95280 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 270621 270621 0 0.0
.text 4427107 4427107 0 0.0
bridge-app debug (read only) 2772553 2772553 0 0.0
(read/write) 133200 133200 0 0.0
.bss 51736 51736 0 0.0
.data 3696 3696 0 0.0
.data.rel.ro 71648 71648 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213280 213280 0 0.0
.text 2381507 2381507 0 0.0
chip-tool debug (read only) 10353257 10353257 0 0.0
(read/write) 443032 443032 0 0.0
.bss 93688 93688 0 0.0
.data 4962 4962 0 0.0
.data.rel.ro 337136 337136 0 0.0
.dynamic 624 624 0 0.0
.got 5808 5808 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 387249 387249 0 0.0
.text 9368963 9368963 0 0.0
chip-tool-ipv6only arm64 (read only) 10217028 10217028 0 0.0
(read/write) 505544 505544 0 0.0
.bss 103048 103048 0 0.0
.data 4288 4288 0 0.0
.data.rel.ro 374376 374376 0 0.0
.dynamic 512 512 0 0.0
.got 18376 18376 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 316048 316048 0 0.0
.text 9134712 9134712 0 0.0
lighting-app debug+rpc+ui (read only) 5254609 5254609 0 0.0
(read/write) 222792 222792 0 0.0
.bss 118160 118160 0 0.0
.data 4400 4400 0 0.0
.data.rel.ro 92640 92640 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 336372 336372 0 0.0
.text 4675443 4675443 0 0.0
lock-app debug (read only) 4478641 4478641 0 0.0
(read/write) 203128 203128 0 0.0
.bss 113424 113424 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 79288 79288 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 246973 246973 0 0.0
.text 4022051 4022051 0 0.0
ota-provider-app debug (read only) 4130529 4130529 0 0.0
(read/write) 192032 192032 0 0.0
.bss 113568 113568 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 68656 68656 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 200093 200093 0 0.0
.text 3739875 3739875 0 0.0
ota-requestor-app debug (read only) 4223721 4223721 0 0.0
(read/write) 196280 196280 0 0.0
.bss 114592 114592 0 0.0
.data 4144 4144 0 0.0
.data.rel.ro 71632 71632 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 203389 203389 0 0.0
.text 3825443 3825443 0 0.0
shell debug (read only) 3055737 3055737 0 0.0
(read/write) 153712 153712 0 0.0
.bss 61000 61000 0 0.0
.data 784 784 0 0.0
.data.rel.ro 86008 86008 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 212576 212576 0 0.0
.text 2668498 2668498 0 0.0
thermostat-no-ble arm64 (read only) 4366428 4366428 0 0.0
(read/write) 242008 242008 0 0.0
.bss 122184 122184 0 0.0
.data 2792 2792 0 0.0
.data.rel.ro 100672 100672 0 0.0
.dynamic 512 512 0 0.0
.got 11904 11904 0 0.0
.init 24 24 0 0.0
.init_array 424 424 0 0.0
.rodata 161052 161052 0 0.0
.text 3870584 3870584 0 0.0
tv-app debug (read only) 5322001 5322001 0 0.0
(read/write) 350696 350696 0 0.0
.bss 241888 241888 0 0.0
.data 5008 5008 0 0.0
.data.rel.ro 96384 96384 0 0.0
.dynamic 624 624 0 0.0
.got 5608 5608 0 0.0
.init 27 27 0 0.0
.init_array 1152 1152 0 0.0
.rodata 271213 271213 0 0.0
.text 4806707 4806707 0 0.0
tv-casting-app debug (read only) 8300185 8300185 0 0.0
(read/write) 211744 211744 0 0.0
.bss 54784 54784 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 147696 147696 0 0.0
.dynamic 624 624 0 0.0
.got 5080 5080 0 0.0
.init 27 27 0 0.0
.init_array 1080 1080 0 0.0
.rodata 337208 337208 0 0.0
.text 7561507 7561507 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2523592 2523592 0 0.0
.bss 219064 219064 0 0.0
.data 5128 5128 0 0.0
.text 1486276 1486276 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1242908 1242908 0 0.0
bss 155134 155134 0 0.0
rodata 143040 143040 0 0.0
text 865796 865796 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1361488 1361488 0 0.0
bss 140544 140544 0 0.0
rodata 137020 137020 0 0.0
text 793244 793244 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1165236 1165236 0 0.0
bss 154564 154564 0 0.0
rodata 113768 113768 0 0.0
text 817940 817940 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837512 837512 0 0.0
(read/write) 1798548 1798548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193300 193300 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2528 2528 0 0.0
.debug_abbrev 1388115 1388115 0 0.0
.debug_aranges 146344 146344 0 0.0
.debug_frame 486696 486696 0 0.0
.debug_info 33101796 33101796 0 0.0
.debug_line 4207748 4207748 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2314599 2314599 0 0.0
.debug_rnglists 147750 147750 0 0.0
.debug_str 4557229 4557229 0 0.0
.heap 837512 837512 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 864731 864731 0 0.0
.symtab 519440 519440 0 0.0
.text 1594332 1594332 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 840168 840168 0 0.0
(read/write) 1685628 1685628 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190708 190708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1256792 1256792 0 0.0
.debug_aranges 136000 136000 0 0.0
.debug_frame 457584 457584 0 0.0
.debug_info 28792655 28792655 0 0.0
.debug_line 3914330 3914330 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2129629 2129629 0 0.0
.debug_rnglists 136895 136895 0 0.0
.debug_str 3942412 3942412 0 0.0
.heap 840168 840168 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 734658 734658 0 0.0
.symtab 472672 472672 0 0.0
.text 1484068 1484068 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 846496 846496 0 0.0
(read/write) 1611268 1611268 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184492 184492 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2352 2352 0 0.0
.debug_abbrev 1097743 1097743 0 0.0
.debug_aranges 126064 126064 0 0.0
.debug_frame 420516 420516 0 0.0
.debug_info 23914633 23914633 0 0.0
.debug_line 3489136 3489136 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1966354 1966354 0 0.0
.debug_rnglists 126447 126447 0 0.0
.debug_str 3749506 3749506 0 0.0
.heap 846496 846496 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 649850 649850 0 0.0
.symtab 434912 434912 0 0.0
.text 1416036 1416036 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 819232 819232 0 0.0
(read/write) 1642644 1642644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211740 211740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2368 2368 0 0.0
.debug_abbrev 1089933 1089933 0 0.0
.debug_aranges 124696 124696 0 0.0
.debug_frame 415540 415540 0 0.0
.debug_info 23718035 23718035 0 0.0
.debug_line 3439762 3439762 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1941919 1941919 0 0.0
.debug_rnglists 124388 124388 0 0.0
.debug_str 3711500 3711500 0 0.0
.heap 819232 819232 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 622780 622780 0 0.0
.symtab 426080 426080 0 0.0
.text 1420148 1420148 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1178256 1178256 0 0.0
.bss 100616 100616 0 0.0
.data 740 740 0 0.0
.text 625096 625096 0 0.0
lock-app qpg6105+debug (read/write) 1134552 1134552 0 0.0
.bss 95320 95320 0 0.0
.data 744 744 0 0.0
.text 581396 581396 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1157320 1157320 0 0.0
bss 113244 113244 0 0.0
text 814484 814484 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1089176 1089176 0 0.0
bss 122264 122264 0 0.0
text 762282 762282 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 942836 942836 0 0.0
bss 106908 106908 0 0.0
text 655912 655912 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 871160 871160 0 0.0
bss 78144 78144 0 0.0
text 623520 623520 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 871632 871632 0 0.0
bss 67056 67056 0 0.0
text 639968 639968 0 0.0
lighting-app-rpc-shell-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 995704 995704 0 0.0
bss 109168 109168 0 0.0
text 705074 705074 0 0.0
tlsr9528a (read only) 4 4 0 0.0
(read/write) 1040132 1040132 0 0.0
bss 120916 120916 0 0.0
text 729586 729586 0 0.0
lock-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 927484 927484 0 0.0
bss 78836 78836 0 0.0
text 653050 653050 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 956444 956452 8 0.0
bss 105008 105008 0 0.0
text 671956 671960 4 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 874892 874892 0 0.0
bss 78248 78248 0 0.0
text 627562 627562 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 816908 816908 0 0.0
bss 66260 66260 0 0.0
text 593380 593380 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 832848 832848 0 0.0
bss 66676 66676 0 0.0
text 604232 604232 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 737688 737688 0 0.0
bss 95176 95176 0 0.0
text 483358 483358 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 873136 873136 0 0.0
bss 78228 78228 0 0.0
text 626428 626428 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 858244 858244 0 0.0
bss 77948 77948 0 0.0
text 613686 613686 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 838420 838420 0 0.0
bss 66560 66560 0 0.0
text 609160 609160 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 835568 835568 0 0.0
bss 66912 66912 0 0.0
text 605886 605886 0 0.0

@mergify mergify bot merged commit dc840f8 into project-chip:master Sep 25, 2023
52 checks passed
bzbarsky-apple
bzbarsky-apple reviewed Sep 27, 2023
View reviewed changes
src/platform/ESP32/nimble/BLEManagerImpl.cpp
@@ -1006,7 +1006,7 @@ CHIP_ERROR BLEManagerImpl::ConfigureScanResponseData(ByteSpan data)
}
memcpy(scanResponseBuffer, data.data(), data.size());
ByteSpan scanResponseSpan(scanResponseBuffer);
mScanResponse = chip::Optional(scanResponseSpan);
mScanResponse = chip::Optional<ByteSpan>(scanResponseSpan);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, @jadhavrohit924, something like mScanResponse = chip::MakeOptional(scanResponseSpan); might be simpler

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jadhavrohit924 Please check

HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@jadhavrohit924 @HunsupJung
[ESP32] Fix template argument for scan response (project-chip#29437)
3d4b7a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 andy31415 approved these changes

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
esp32 platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jadhavrohit924 @andy31415 @dhrishi @bzbarsky-apple @Damian-Nordic