Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics at the AppWrapper granularity #118

Open
ronensc opened this issue Dec 26, 2023 · 0 comments
Open

Metrics at the AppWrapper granularity #118

ronensc opened this issue Dec 26, 2023 · 0 comments

Comments

@ronensc
Copy link
Contributor

ronensc commented Dec 26, 2023

It could be beneficial to introduce metrics at the granularity of AppWrappers.
For metrics such as consumed memory, this approach would enable us to aggregate data on AppWrappers, providing the total memory consumption across all nodes for a specific AppWrapper. Additionally, we could aggregate on nodes to identify overloaded nodes.
Assuming we can relate AppWrappers to users, this would also allow us to obtain resource consumption metrics per user.

For example:

used_memory{appwrapper="aw1",node="worker1"} 100MiB
used_memory{appwrapper="aw1",node="worker2"} 200MiB
used_memory{appwrapper="aw1",node="worker3"} 300MiB
used_memory{appwrapper="aw2",node="worker1"} 400MiB
used_memory{appwrapper="aw2",node="worker3"} 500MiB

Aggregating by AppWrapper:

sum by (appwrapper) (used_memory)

used_memory{appwrapper="aw1"} 600MiB
used_memory{appwrapper="aw2"} 900MiB

Aggregating by Node:

sum by (node) (used_memory)

used_memory{node="worker1"} 500MiB
used_memory{node="worker2"} 200MiB
used_memory{node="worker3"} 800MiB

However, a potential concern arises with high label cardinality if there are too many AppWrappers. One solution could be to implement this feature behind a feature flag, allowing operators who specifically require this functionality to utilize it.

@tardieu @dgrove-oss WDYT?

cc @eranra @rachelt44 @maia-iyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant