Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource accounting for common resource types #91

Open
tardieu opened this issue Dec 11, 2023 · 1 comment
Open

Resource accounting for common resource types #91

tardieu opened this issue Dec 11, 2023 · 1 comment

Comments

@tardieu
Copy link
Member

tardieu commented Dec 11, 2023

MCAD should parse common types such as Pods, Jobs, PytorchJobs, RayClusters, Deployments, StatefulSets to extract resource requirements.

@dgrove-oss
Copy link
Collaborator

dgrove-oss commented Dec 14, 2023

As part of implementing this feature, we need to specify the semantics for what should happen if the user-provided resource specification at the AppWrapper level is inconsistent with the resource specifications of the wrapped resources. Once we define the semantics, we need to include test cases for it.

There were a couple of tests in the V1 MCAD test suite targeting inconsistent resource specifications that I did not port to V2 because they need to be redone in the context of the V2 specification of the desired behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants