Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CH EMED EPR: missing getters/setters for performer and wasSubstituted on MedicationDispense #154

Closed
qligier opened this issue Jul 17, 2024 · 4 comments · Fixed by #159
Closed

CH EMED EPR: missing getters/setters for performer and wasSubstituted on MedicationDispense #154

qligier opened this issue Jul 17, 2024 · 4 comments · Fixed by #159
Assignees
@qligier
Labels
enhancement New feature or request

Comments

@qligier
Copy link
Member

qligier commented Jul 17, 2024

On ChEmedEprMedicationDispense, there are no convenience setters or getters for the performer and wasSubstituted (see CHEMEDEPRMedicationDispense).
@qligier qligier added the enhancement New feature or request label Jul 17, 2024
@qligier qligier self-assigned this Jul 17, 2024
@dvribeira
Copy link
Collaborator

dvribeira commented Jul 17, 2024 •
edited
Loading

resolveMedicalAuthor as implementation of the ChEmedEprEntry interface returns the performer (as an Author) if that is the kind of convenience getter you would like to have, that keeps it coherent with the rest of the resources (to use the same nomenclature), but you can add an extra method for this as well ofc

@qligier
Copy link
Member Author

qligier commented Jul 17, 2024

Right, thanks! I can make resolveMedicalAuthor() return a PractitionerRole, as set in the IG.

@dvribeira
Copy link
Collaborator

Ah I see, that's what you wanted, then you will need another method, otherwise it will break the implementation of the ChEmedEprEntry interface.

@qligier
Copy link
Member Author

qligier commented Jul 17, 2024

Ah, I forgot it comes from an interface. Then yes, I guess having two methods (Author resolveMedicalAuthor() and ChEmedEprPractitionerRole resolvePerformer()) will be a good solution.

@qligier qligier mentioned this issue Jul 18, 2024
Merged
@qligier qligier mentioned this issue Jul 18, 2024
Merged
@qligier qligier linked a pull request Jul 18, 2024 that will close this issue
CH EMED EPR: Add ChEmedEprMedicationDispense#resolvePerformer() #159
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qligier qligier

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CH EMED EPR: Add ChEmedEprMedicationDispense#resolvePerformer() project-husky/husky
2 participants
@qligier @dvribeira