Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection manifest will drop connections after 24 hours #206

Open
ghjm opened this issue Apr 15, 2020 · 2 comments
Open

Connection manifest will drop connections after 24 hours #206

ghjm opened this issue Apr 15, 2020 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@ghjm
Copy link
Contributor

ghjm commented Apr 15, 2020

The connection manifest writes connections to disk so that a node can remember, after restart, what connections it used to have, even if they happen to be down right now. This allows it to buffer messages for a connection that might come back up soon.

As far as I can see, the connection manifest's update method only gets called when a node connects or disconnects. So on a stable network where nodes have remained connected for more than 24 hours, the watch_expire process will drop nodes from the manifest, even though they are still active.

@matburt
Copy link
Member

matburt commented Apr 16, 2020

This probably just needs a test to see if this connection is active and if it is it can skip over it. connects/disconnects will update this time.

@matburt matburt added the bug Something isn't working label Apr 16, 2020
@matburt matburt added this to the 1.0 Release milestone May 13, 2020
@ghjm
Copy link
Contributor Author

ghjm commented May 15, 2020

It's not good enough for connects/disconnects to update the time. We hope these connections will be up and stable for weeks, months or years at a time. We probably need to update on traffic, or have a background task that resets the time periodically as long as the connection is still up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants