Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add the all build tag to extensions #2539

Open
AndersBennedsgaard opened this issue Jul 12, 2024 · 0 comments
Open

[Feat]: Add the all build tag to extensions #2539

AndersBennedsgaard opened this issue Jul 12, 2024 · 0 comments
Labels
feature New feature or request rm-external Roadmap item submitted by non-maintainers

Comments

@AndersBennedsgaard
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Since we have a lot of different build tags for different components, and not all tools (like gopls and golangci-lint) supports ignoring build tags, it means that you have to manually add all these build tags when you use these tools. This can for example be seen here:

args: --config ./golangcilint.yaml --enable-all --build-tags debug,needprivileges,sync,scrub,search,userprefs,metrics,containers_image_openpgp,lint,mgmt,imagetrust ./cmd/... ./pkg/...

Whenever a new build tag is introduced (such as coming from a new extension), we have to add there here

Describe the solution you'd like

I propose that we add an additional tag called all wherever we use build tags, such that we only have to use that tag when building the full Zot binary with all extensions, and gopls is easier to configure:

// +build sync all

Describe alternatives you've considered

No response

Additional context

No response

@AndersBennedsgaard AndersBennedsgaard added the feature New feature or request label Jul 12, 2024
@rchincha rchincha added the rm-external Roadmap item submitted by non-maintainers label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request rm-external Roadmap item submitted by non-maintainers
Projects
None yet
Development

No branches or pull requests

2 participants