Allowing not to build param: this will clean up any logger of any lib… #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary built using scarab (if desired)
nsoblath
requested changes
Jun 20, 2018
There was a problem hiding this comment.
These changes do not properly account for the dependencies between the different optionally-built parts of scarab. If we're going to make param optional, we really should have a block of the CMakeLists.txt file that handles the logic of the dependencies. The dependencies are that each of the codecs requires param, and authentication requires the JSON codec.
added 2 commits
June 20, 2018 14:12
|
Adding extra logic to handle the dependencies: authentication depends on codec_json which depends on param |
…am module to the right place.
…st_yaml and test_configurator
…urns on and off the option to use command-line JSON in configurator.
… into feature/no_param_builder # Conflicts: # library/CMakeLists.txt
…ld options and build option dependencies. CMakeLists.txt updated to require that dependent options be set correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rary built using scarab (if desired).
Other libraries generally don't use the factories, but codec factories get registered anyway, leading to an useless verbosity.
Adding an option not to build param (which is responsible for this registration) has been added.
Basically, this makes Cicada loading less verbose: from
to