moving param binding helper implementations into header #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the two helper function implementations back into the headers.
This is because as source, they are used to build libraries of type
MODULE_LIBRARY
(which are not able to be linked). That isn't a problem for scarab itself, but means that packages which include scarab cannot link those implementations for other libs.There is some discussion elsewhere (pybind/cmake_example#11 (comment)) about how to achieve a more desirable pattern (with headers defining the bindings themselves, but required non-trivial implementations in source files and building a supporting library that can be linked elsewhere). We don't currently have bandwidth to continue exploring those patterns.