jack does not build #105

ycollet · 2018-09-20T18:22:54Z

In the current cmake branch, the jack version of projectm is not buildable.
The CMakeLists.txt file is missing in the jack directory.

revmischa · 2018-09-20T19:17:25Z

it uses autotools now. a makefile and configure needs to be added for jack.

ycollet · 2018-09-21T08:44:00Z

Maybe, in the mean time, you should add back the CMakeLists.txt file. And removes it when the configure script will be ready.

…

----- Mail original ----- De: "Mischa Spiegelmock" <notifications@github.com> À: "projectM-visualizer/projectm" <projectm@noreply.github.com> Cc: "ycollet" <ycollette.nospam@free.fr>, "Author" <author@noreply.github.com> Envoyé: Jeudi 20 Septembre 2018 21:17:30 Objet: Re: [projectM-visualizer/projectm] jack does not build (#105) it uses autotools now. a makefile and configure needs to be added for jack. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

ionenwks · 2018-10-09T03:46:31Z

Is the jack specific version even necessary anymore? I tried to build this again recently (been a few years since last used it) and was annoyed by this at first but then I realized SDL2 has full Jack support now (I did need to build my own libsdl since current Debian omitted the jack support). Set the SDL_AUDIODRIVER=jack connected the ports and there it was, reading the audio seemingly fine. Not that I experimented much with this yet.

revmischa · 2018-10-09T06:51:35Z

add back the CMakeLists.txt file

Not sure if that's how it works... I think it requires the rest of the project be built with cmake

ycollet · 2018-10-09T07:32:11Z

There is two possibility: - first, you can add back the cmake into the jack directory and the jack part will just require a separate build - add an autoconf / automake file to build the jack part.

…

----- Mail original ----- De: "Mischa Spiegelmock" <notifications@github.com> À: "projectM-visualizer/projectm" <projectm@noreply.github.com> Cc: "ycollet" <ycollette.nospam@free.fr>, "Author" <author@noreply.github.com> Envoyé: Mardi 9 Octobre 2018 08:51:43 Objet: Re: [projectM-visualizer/projectm] jack does not build (#105) add back the CMakeLists.txt file Not sure if that's how it works... I think it requires the rest of the project be built with cmake — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .

revmischa · 2018-11-17T12:46:07Z

What is the use case for having a dedicated jack version? What do you think about what @ionenwks said?
Feel free to contribute a Makefile.am for the jack version

revmischa · 2019-02-09T21:42:00Z

Added jack makefile here - #163 please give it a try!

TildeSlashC0re · 2019-02-10T23:50:26Z

qprojectM-jack.cpp: In function ‘std::__cxx11::string read_config()’:
qprojectM-jack.cpp:95:10: warning: declaration of ‘out’ shadows a global declaration [-Wshadow]
    FILE *out;
          ^~~
qprojectM-jack.cpp:47:29: note: shadowed declaration is here
 jack_default_audio_sample_t out[1024*1000];
                             ^~~
qprojectM-jack.cpp:91:8: warning: unused variable ‘n’ [-Wunused-variable]
    int n;
        ^
qprojectM-jack.cpp: In function ‘int main(int, char**)’:
qprojectM-jack.cpp:204:7: warning: unused variable ‘projectM_data’ [-Wunused-variable]
  char projectM_data[1024];
       ^~~~~~~~~~~~~
depbase=`echo ConfigFile.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
g++ -DHAVE_CONFIG_H -I. -I../..  -Wall -Wchar-subscripts -Wformat-security -Wpointer-arith -Wshadow -Wsign-compare -Wtype-limits -DDATADIR_PATH=\""/usr/local/share/projectM"\" -I../../vendor  -include ../../config.h -DSYSCONFDIR=\""/usr/local/etc"\" -DPROJECTM_PREFIX=\""/usr/local"\" -DRESOURCE_PREFIX=\""share/projectM"\" -I../../src/libprojectM -I../../src/libprojectM/Renderer -I../../src/projectM-qt  -I/usr/include/x86_64-linux-gnu/qt5/QtOpenGL -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtWidgets -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtGui -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtCore -I/usr/include/x86_64-linux-gnu/qt5  -fPIC -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CORE_LIB -I/usr/include/x86_64-linux-gnu/qt5/QtOpenGL -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtWidgets -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtGui -I/usr/include/x86_64-linux-gnu/qt5 -I/usr/include/x86_64-linux-gnu/qt5/QtCore -I/usr/include/x86_64-linux-gnu/qt5   -g -O2 -pthread -std=c++11 -MT ConfigFile.o -MD -MP -MF $depbase.Tpo -c -o ConfigFile.o ConfigFile.cpp &&\
mv -f $depbase.Tpo $depbase.Po
/bin/bash ../../libtool  --tag=CXX   --mode=link g++  -g -O2 -pthread -std=c++11 -static -fPIC   -o projectM_jack qprojectM-jack.o ConfigFile.o ../projectM-qt/libprojectM_qt.a -ljack -lQt5OpenGL -lQt5Widgets -lQt5Gui -lQt5Core -lGL  -ldl  -pthread ../libprojectM/libprojectM.la -lSDL -lGL  -ldl  -pthread
libtool: link: g++ -g -O2 -pthread -std=c++11 -fPIC -o projectM_jack qprojectM-jack.o ConfigFile.o -pthread -pthread  ../projectM-qt/libprojectM_qt.a -ljack -lQt5OpenGL -lQt5Widgets -lQt5Gui -lQt5Core ../libprojectM/.libs/libprojectM.a -lSDL -lGL -ldl -pthread
/usr/bin/ld: cannot find -lSDL
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:481: projectM_jack] Error 1
make[3]: Leaving directory '/home/c0re/.build/projectm/src/projectM-jack'
make[2]: *** [Makefile:451: all-recursive] Error 1
make[2]: Leaving directory '/home/c0re/.build/projectm/src'
make[1]: *** [Makefile:521: all-recursive] Error 1
make[1]: Leaving directory '/home/c0re/.build/projectm'
make: *** [Makefile:411: all] Error 2

my result so far :<

EDIT: Being on debian buster a quick apt-get install libsdl1.2-dev resolved the roadblock shown above :)

tank-trax · 2019-02-21T16:13:46Z

@revmischa

I managed to build your JACK version

It works but only has a mono input

the 'n' key for next, 'r' for random and 'p' for previous all are active and functional

r/clicking on screen does not bring up the menu
double clicking does not enable full screen
has xruns on exit

ERROR: JackEngine::XRun: client = projectM_jack was not finished, state = Triggered
ERROR: JackAudioDriver::ProcessGraphAsyncMaster: Process error

tank-trax · 2019-02-21T18:26:25Z

this is the output when run from the terminal

user@hostname:$ /usr/local/bin/projectM_jack
dir:/usr/local/share/projectM/config.inp
reading ~/.projectM/config.inp
[projectM] config file: /home/user/.projectM/config.inp
[PresetFactory] url is idle://Geiss & Sperl - Feedback (projectM idle HDR mix).milk
No Textures Loaded from /usr/local/share/projectM/textures
No Textures Loaded from /usr/local/share/projectM/textures
engine sample rate: 48000
Connecting to Jack port system:capture_1
Connecting to Jack port system:capture_2
Connecting to Jack port a2j:Midi Through [14] (capture): Midi Through Port-0
Connecting to Jack port a2j:Midi Through [14] (capture): Midi Through Port-1
Connecting to Jack port a2j:Midi Through [14] (capture): Midi Through Port-2
Connecting to Jack port a2j:Midi Through [14] (capture): Midi Through Port-3
Connecting to Jack port a2j:FastTrack Pro [16] (capture): FastTrack Pro MIDI 1

it will start to load the presets once 'n' is pressed

[PresetFactory] url is /usr/share/projectM/presets/Aderrasi - Agitator.milk
[PresetFactory] url is /usr/share/projectM/presets/Aderrasi - Aimless (Gravity Directive Mix).milk
[PresetFactory] url is /usr/share/projectM/presets/Aderrasi - Aimless (Spirogravity Mix).milk
[PresetFactory] url is /usr/share/projectM/presets/Aderrasi - Airhandler (Menagerie Mix).milk

revmischa · 2019-02-21T21:09:25Z

cool!

tank-trax · 2019-02-21T21:35:21Z

The visualizations work when audio is pumped through the projectM_jack input.

if I may add some suggestions:

a stereo input would be nice :-)
to figure out how to not have the a2j recognized as Audio (I think this may be the cause of the xrun on closing), as those are connections that would normally be seen in ALSA MIDI but with a2jmidid enabled they can be used with JACK

Note: a few DAWS list this a2j in their Audio configuration sections but it should be in the MIDI section.

======================

Are you planning on developing it further for JACK? if so I would be interested to assist with testing. FYI, I use Debian 9 with KXStudio repos added.

tank-trax · 2019-02-21T21:38:39Z

I also had to install the following to complete the build

sudo apt-get install libsdl-image1.2-dev libsdl-ttf2.0-dev

revmischa · 2019-02-22T09:00:57Z

PRs very welcome! :)

tank-trax · 2019-03-01T20:57:40Z

built this successfully, installation went well but had to create a shortcut/menu entry for KDE for quick launch

all keyboard shortcuts work (CTRL+M, CTRL+E...)

under Settings -> there is one entry -> Configure projectM (all good)
there is no entry for Audio settings
Audio is still mono -> ideally it would be stereo

first time I built it with ./configure the visualizations would not load or play
second time used ./configure --enable-gles and it worked

my apologies I do not know how to create/open a new a PR

revmischa · 2019-03-03T09:35:28Z

second time used ./configure --enable-gles and it worked

Noted in #168

revmischa · 2019-03-03T09:36:42Z

Jack build support is in master now. Please test it out!
If you have feature requests feel free to open tickets for them specifically so we can track them. Or better yet, contribute some code!
You can read about PRs on GitHub's help pages

revmischa added the good first issue label Jan 22, 2019

revmischa closed this as completed Mar 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

jack does not build #105

jack does not build #105

ycollet commented Sep 20, 2018

revmischa commented Sep 20, 2018

ycollet commented Sep 21, 2018 via email

ionenwks commented Oct 9, 2018

revmischa commented Oct 9, 2018 •

edited

Loading

ycollet commented Oct 9, 2018 via email

revmischa commented Nov 17, 2018

revmischa commented Feb 9, 2019

TildeSlashC0re commented Feb 10, 2019 •

edited

Loading

tank-trax commented Feb 21, 2019

tank-trax commented Feb 21, 2019

revmischa commented Feb 21, 2019

tank-trax commented Feb 21, 2019

tank-trax commented Feb 21, 2019

revmischa commented Feb 22, 2019

tank-trax commented Mar 1, 2019 •

edited

Loading

revmischa commented Mar 3, 2019 •

edited

Loading

revmischa commented Mar 3, 2019

jack does not build #105

jack does not build #105

Comments

ycollet commented Sep 20, 2018

revmischa commented Sep 20, 2018

ycollet commented Sep 21, 2018 via email

ionenwks commented Oct 9, 2018

revmischa commented Oct 9, 2018 • edited Loading

ycollet commented Oct 9, 2018 via email

revmischa commented Nov 17, 2018

revmischa commented Feb 9, 2019

TildeSlashC0re commented Feb 10, 2019 • edited Loading

tank-trax commented Feb 21, 2019

tank-trax commented Feb 21, 2019

revmischa commented Feb 21, 2019

tank-trax commented Feb 21, 2019

tank-trax commented Feb 21, 2019

revmischa commented Feb 22, 2019

tank-trax commented Mar 1, 2019 • edited Loading

revmischa commented Mar 3, 2019 • edited Loading

revmischa commented Mar 3, 2019

revmischa commented Oct 9, 2018 •

edited

Loading

TildeSlashC0re commented Feb 10, 2019 •

edited

Loading

tank-trax commented Mar 1, 2019 •

edited

Loading

revmischa commented Mar 3, 2019 •

edited

Loading