Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile applications using libprojectM due to missing header #468

Closed
ericonr opened this issue Feb 20, 2021 · 1 comment
Closed

Can't compile applications using libprojectM due to missing header #468

ericonr opened this issue Feb 20, 2021 · 1 comment

Comments

@ericonr
Copy link

ericonr commented Feb 20, 2021

Hi! f7f74b1 seems to have reorganized a bunch of stuff, which included switching from using the __SSE2__ macro to your own _HAS_SSE2_ one, using a dedicated header to (I assume) avoid duplicating code.

Unfortunately, the new Intrinsics.h header was included directly in Common.h, but isn't installed, which lead to build failures for applications which can link to a system projectM (in our case, the clementine player and qmmp).

I don't know if the preferred course of action is installing the new header or making it internal only (which IMO would be better, since it seems to be only an implementation detail), so I'm not opening a PR for now.

@revmischa
Copy link
Collaborator

Thanks for the report, I just ran into this myself. You're entirely right. That file ended up being pointless anyway. I was trying to work around multi-arch compilation issues for amd64/aarch64 for macOS but this didn't help.
I've reverted the change and done away with Intrinsics.h - b3c3282
I wasn't aware of qmmp, please add it to the README!
Feel free to chat w/ us on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants