Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move closer to upstream ClientIDMutation #1081

Open
sbor23 opened this issue Jun 8, 2020 · 1 comment
Open

Move closer to upstream ClientIDMutation #1081

sbor23 opened this issue Jun 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@sbor23
Copy link

sbor23 commented Jun 8, 2020

Our Mutation is a homebrew solution to fix some issues with the graphene-django ClientIDMutation.
Now I don't know all the background of this, but #985 shows that we are running into issues with this now, because it seems like the SaveDocumentInput InputType doesn't know about the id which is passed.
See https://travis-ci.com/github/projectcaluma/caluma/jobs/343595361#L2099

The Mutation links three upstream issues that led to the custom implementation: https://github.com/projectcaluma/caluma/blob/master/caluma/caluma_core/mutation.py#L79

Should be considered a show-stopper for #814

Who knows enough about the graphene internals to tackle this?

@sbor23 sbor23 added the enhancement New feature or request label Jun 8, 2020
@sbor23
Copy link
Author

sbor23 commented Jun 8, 2020

It's not as grave is I feared, the specific issue we're facing is tracked here: graphql-python/graphene-django#906

But we should still consider trying to upstream the changes mentioned in said docstrings, the issues on graphene-django are all stale although solutions have been posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant