-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how to integrate with Linkerd #2089
Comments
Linkerd blocks the proxy injection into Envoy pods see linkerd/linkerd2#3910 |
With linkerd edge-20.3.1 linkerd no longer blocks the proxy injection into envoy / contour pods. Using linkerd with contour/envoy works but a lot of configuration is required since you need to set the Is it somehow possible to automatically add those headers? Either by adding a config flag to contour, similar to ambassador ( apiVersion: projectcontour.io/v1
kind: HTTPProxy
metadata:
name: test
spec:
routes:
- requestHeadersPolicy:
set:
- name: l5d-dst-override
value: ${SVC_NAME}.${SVC_NAMESPACE}.svc.cluster.local:${SVC_PORT}
services:
- name: test
namespace: default
port: 80 |
Thanks for checking on this @arminbuerkle. I'm not sure that we would consider it in scope for Contour to have direct support for Linkerd headers. Perhaps you could do that with a modifying admission controller? |
thanks @jpeach for the suggestion. An admission controller might be the way to go. Regardless, are there any plans for contour to support variables like mentioned above for headers rewrite, or even prefix matching? Other than that i think this issue can be closed. Linkerd has a documentation of how to use it with contour. |
We could add a requestHeaders section to the The idea was to apply "defaults" to all the routes under that vhost. They could still override them, however, if someone wanted a default something (in this case header added), you could define it at the vhost level and Contour would apply to all the routes automatically down the tree. |
Now that Contour supports injecting HTTP headers, it should be possible to configure Contour as a Linkerd Ingress. We should verify and document how to do this.
The text was updated successfully, but these errors were encountered: