Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

featuretests: TestIngressClassUpdate passes but shouldn't #2964

Closed
youngnick opened this issue Oct 1, 2020 · 2 comments
Closed

featuretests: TestIngressClassUpdate passes but shouldn't #2964

youngnick opened this issue Oct 1, 2020 · 2 comments
Labels
area/testing Issues or PRs related to tests or testing tools. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@youngnick
Copy link
Member

The featuretest TestIngressClassUpdate creates an object with a given ingress class, checks that it is processed correctly, then updates that object so it does not have the same ingress class, and checks that its status has been cleared.

Because of changes to the way we send status updates, this test does not reflect what Contour actually does; currently, Contour will leave the status of objects that fall out of scope alone and not clear them.

When updating featuretests for #2495, this test is breaks and is not easily fixable. I've marked it to skip for now, this is a tracking issue to come back and fix this.

Currently, the test checks for the status being blank, if we want this test to pass, we're going to have to actually do that and send the update to the apiserver. Currently, we don't support clearing status.

@youngnick youngnick added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/testing Issues or PRs related to tests or testing tools. labels Oct 1, 2020
Copy link

github-actions bot commented Jan 8, 2024

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 8, 2024
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to tests or testing tools. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant