Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RateLimit flag #122

Closed
dogancanbakir opened this issue Jul 19, 2023 · 0 comments · Fixed by #123
Closed

Add RateLimit flag #122

dogancanbakir opened this issue Jul 19, 2023 · 0 comments · Fixed by #123
Assignees
@dogancanbakir
Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.

Comments

@dogancanbakir
Copy link
Member

dogancanbakir commented Jul 19, 2023 •
edited
Loading

Proposed changes

we can consider adding new flag type in goflags for ratelimit which accepts ratelimit along with unit

type RateLimit struct{
   MaxTokens unit
   Duration    time.Duration
}

rls := []RateLimit{}
flag.RateLimitVar(&rls, "-rls",nil,"rate limit along with unit ex:  10/ms , 30/m, 8/s ")

ref: projectdiscovery/subfinder#891 (review)
@dogancanbakir dogancanbakir self-assigned this Jul 19, 2023
@dogancanbakir dogancanbakir mentioned this issue Jul 19, 2023
Merged
@ehsandeep ehsandeep added the Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dogancanbakir dogancanbakir

Labels
Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ratelimit flag dogancanbakir/goflags
2 participants
@ehsandeep @dogancanbakir