Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude option still has bugs in version 1.5.0 #1615

Closed
ipsecc opened this issue Mar 5, 2024 · 5 comments
Closed

exclude option still has bugs in version 1.5.0 #1615

ipsecc opened this issue Mar 5, 2024 · 5 comments
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@ipsecc
Copy link

ipsecc commented Mar 5, 2024

httpx version:

1.5.0

Description:

Hi team, I created an issue last month, thanks for the quick response. However, after my test, there are still bugs in some scenarios.

Flag "*" not work:

root@ubuntu:~# httpx -u docs.hackerone.com -exclude "doc*.hackerone.com" -v

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.5.0 (latest)
https://docs.hackerone.com

Got the wrong output:

root@ubuntu:~# httpx -u durobotdev.baidu.com:8080 -exclude "docs.hackerone.com" -v

    __    __  __       _  __
   / /_  / /_/ /_____ | |/ /
  / __ \/ __/ __/ __ \|   /
 / / / / /_/ /_/ /_/ /   |
/_/ /_/\__/\__/ .___/_/|_|
             /_/

                projectdiscovery.io

[INF] Current httpx version v1.5.0 (latest)
[DBG] Skipping target due to network policy: durobotdev.baidu.com
[DBG] Failed 'durobotdev.baidu.com:8080': target host is not allowed by network policy
@ipsecc ipsecc added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Mar 5, 2024
@dogancanbakir dogancanbakir self-assigned this Mar 5, 2024
@dogancanbakir
Copy link
Member

Thanks for opening this issue. See #1597 (review) - so, it should be httpx -u docs.hackerone.com -exclude "doc.\.hackerone\.com" -v. Feel free to let me know if you have any questions.

@ipsecc
Copy link
Author

ipsecc commented Mar 5, 2024

Thanks for the reply @dogancanbakir, and how about httpx -u durobotdev.baidu.com:8080 -exclude "docs\.hackerone\.com" -v, why target host is excluded, even it's not in the network policy.

@dogancanbakir
Copy link
Member

Great catch! I raised a PR at projectdiscovery/networkpolicy#72, and I'll fix this once the PR is merged.

@dogancanbakir
Copy link
Member

Depends on projectdiscovery/networkpolicy#71

@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Mar 6, 2024
@ehsandeep
Copy link
Member

should be fixed with latest release - https://github.com/projectdiscovery/httpx/releases/tag/v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

3 participants