Add support more favicon types (-favicon mmh3 probe enchant) #1842
Labels
Status: Completed
Nothing further to be done with this issue. Awaiting to be closed.
Type: Bug
Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
httpx version:
v1.6.6
Current Behavior:
Some sites do not adhere to the standard of using .ico format in the html tag
<link rel="shortcut icon"...>
.It can be contain svg, png, jpg, jpeg, gif and less often base64 encoded string 🤯
Currently this project only supports .ico for this probe method.
Expected Behavior:
Add more formats support for probe favicon's. sometimes it doesn't find
Steps To Reproduce:
I collect several examples of sites in the wild for testing for next format:
Anything else:
Other refs that might help:
rel='shortcut icon'
attr and formats other than.ico
. I added this link just for funThe text was updated successfully, but these errors were encountered: