Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially switch to github.com/gopacket/gopacket instead of github.com/google/gopacket ? #1082

Closed
steev opened this issue May 15, 2024 · 1 comment · Fixed by #1083
Assignees
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Type: Investigation

Comments

@steev
Copy link

steev commented May 15, 2024

Debian testing has applied patches and rebuilt almost their entire repository in order to have 32bit architectures report time type as _TIME_BITS=64 - because of this change, it seems that the google/gopacket dependency now causes a failure to build on 32bit arm architectures c.f. https://gitlab.com/kalilinux/packages/naabu/-/jobs/6843360661#L1515

The Debian go maintainers submitted a patch to gopacket/gopacket which seems like it's at least somewhat more actively maintained at gopacket/gopacket#52 which they accepted and merged in.

Experimentally, in Kali, I switched over to using gopacket/gopacket instead, and the build of naabu does seem to work fine, the CI also reports successful builds c.f. https://gitlab.com/kalilinux/packages/naabu/-/jobs/6852393372 , so I'm asking the naabu project to consider moving to the gopacket/gopacket repository, or, if you are uncomfortable with that, perhaps forking the google/gopacket repository, and applying the pull request mentioned above to it, and using that instead?

@steev steev added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 15, 2024
@dogancanbakir dogancanbakir self-assigned this May 15, 2024
@Mzack9999 Mzack9999 linked a pull request May 15, 2024 that will close this issue
@Mzack9999
Copy link
Member

@steev Thanks for this suggestion! We have experimentally switched to the mentioned fork, sadly the original library from google seems almost abandoned (last commit 2y ago). At some point probably we will need to implement some abstracted lightweight implementation supporting transparent libpcap, user space raw sockets and so on, dropping cgo alltogether

@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Type: Investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants