Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing race condition test #480

Closed
ehsandeep opened this issue Nov 18, 2022 · 1 comment · Fixed by #485
Closed

Failing race condition test #480

ehsandeep opened this issue Nov 18, 2022 · 1 comment · Fixed by #485
Assignees
@xm1k3
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@ehsandeep
Copy link
Member

Naabu version:

dev

Current Behavior:

Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:20:6: missing function body
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:20:16: syntax error: unexpected [, expecting (
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:31:6: missing function body
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:31:12: syntax error: unexpected [, expecting (
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:44:6: missing function body
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:44:16: syntax error: unexpected [, expecting (
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:49:6: missing function body
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:49:14: syntax error: unexpected [, expecting (
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:60:6: missing function body
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:60:19: syntax error: unexpected [, expecting (
Error: /root/go/pkg/mod/github.com/projectdiscovery/utils@v0.0.2/slice/sliceutil.go:60:6: too many errors
note: module requires Go 1.18
Error: Process completed with exit code 2.

Steps To Reproduce:

#474
@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Nov 18, 2022
@Mzack9999 Mzack9999 mentioned this issue Nov 21, 2022
Merged
@Mzack9999 Mzack9999 linked a pull request Nov 21, 2022 that will close this issue
Failing race condition #485
Merged
@Mzack9999
Copy link
Member

Not reproducible locally by me and @xm1k3 - It looks specific to the GH box when run as sudo. Since the race coverage needs to be increased with external frameworks, we opted for a lightweight check for non-sudo user.

@Mzack9999 Mzack9999 added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Nov 21, 2022
@xm1k3 xm1k3 closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xm1k3 xm1k3

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Failing race condition projectdiscovery/naabu
3 participants
@ehsandeep @Mzack9999 @xm1k3