Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telegram markdown issue #393

Closed
fopina opened this issue Jul 17, 2024 · 0 comments · Fixed by #395
Closed

Telegram markdown issue #393

fopina opened this issue Jul 17, 2024 · 0 comments · Fixed by #395
Assignees
@dogancanbakir
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@fopina
Copy link

fopina commented Jul 17, 2024 

          How is this PR even merged?

If you escape all _ (and all * as someone else asked) then you're preventing markdown characters to be used.

If you don't want markdown, then don't use markdown parse mode in the provider configuration to start with....!

This broke usage for those actually formatting for markdown...

Originally posted by @fopina in #270 (comment)
@dogancanbakir dogancanbakir self-assigned this Jul 18, 2024
@dogancanbakir dogancanbakir mentioned this issue Jul 22, 2024
Merged
@dogancanbakir dogancanbakir linked a pull request Jul 22, 2024 that will close this issue
fix markdown format #395
Merged
@dogancanbakir dogancanbakir added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 25, 2024
@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dogancanbakir dogancanbakir

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix markdown format projectdiscovery/notify
3 participants
@fopina @ehsandeep @dogancanbakir