Hardcoded icon path in launcher

[palob]

Hi,

currently the icon path specified in the created .desktop launcher file is set to:
Icon=/usr/share/apx/icons/apx.svg

This prevents icon theming without editing the launcher file.

I'd like to ask you to change the icon location as well as the icon path line in the launcher according to the freedesktop.org standards.

Please find more info here:
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
https://github.com/Foggalong/hardcode-fixer/wiki/What,-Why-&-How

According to the above resources standard icon locations are:

/usr/share/icons/hicolor/[size]/apps/[icon name]
~/.local/share/icons/hicolor/[size]/apps/[icon name]
or simply:
/usr/share/pixmaps/[icon name]

The corresponding standard icon line in the .desktop launcher is:
Icon=[icon name] (without full path, without file extension)

for instance
Icon=apx

(for an icon apx.svg or apx.png stored in standard location

Could you please move the icon to one of those locations and adjust the icon path in the .desktop file accordingly?

[tstriker]

@palob - sorry for such a delayed reply - icon has been moved now. i did not manage to make it work without the extension, so desktop file now reads Icon=/usr/share/icons/hicolor/scalable/apx.svg

thank you for reporting the bug!

[palob]

Thanks, it really should work with just Icon=apx now though.
You may need to run gtk-update-icon-cache -f /usr/share/icons/hicolor or logout from your desktop session.

[tstriker]

ya, tried it out (logging out is excessive -> alt+F2 -> "r" is enough) but
doesn't seem to be working.
let me know if and how you get it to work and i'll update the files then! :)

On Sat, 26 Dec 2015 at 02:27 palob notifications@github.com wrote:

Thanks, it really should work with just Icon=apx now though.
You may need to run gtk-update-icon-cache /usr/share/icons/hicolor or
logout from your desktop session.

—
Reply to this email directly or view it on GitHub
#8 (comment).

[Foggalong]

This issue isn't fixed btw, even if it's in the right location if the full path is used then it's still hardcoded :(

[tstriker]

:'(

On Thu, 21 Jan 2016, 17:53 Joshua H. Fogg notifications@github.com wrote:

This issue isn't fixed btw, even if it's in the right location if the full
path is used then it's still hardcoded :(

—
Reply to this email directly or view it on GitHub
#8 (comment).

[bilelmoussaoui]

@tbaugis Hey, in order to fix that you will have to add this line window.set_icon_name("apx") to BasicWindow and change the icon value in the destkop file to apx. Reinstall the application and everything should work fine! 👍