Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #747

Closed
1 of 6 tasks
matthijskooijman opened this issue Nov 20, 2023 · 1 comment · Fixed by #749
Closed
1 of 6 tasks

Small fixes #747

matthijskooijman opened this issue Nov 20, 2023 · 1 comment · Fixed by #749

Comments

@matthijskooijman
Copy link
Member

matthijskooijman commented Nov 20, 2023

Just a few small fixes that I noticed during the 3.0.3 release, that could be made or investigated:

  • Move dbus service files into data/ or another subdir for cleanup. Also maybe move the flatpak file, see Flatpak improvements #743.
  • Drop LIBDIR from defs.py.in (for Debian reproducible builds), and maybe others too (only VERSION and DATADIR seems used).
  • Is data/hamster.db actually used? Does it define the initial db schema, or is it leftover from an old version? Yes, still used.
  • See if we can remove distutils import (it seems deprecated, and according to lintian removed in Python 3.12, though it does still seem to work in 3.12 so far).
  • Strip whitespace from VERSION to allow newlines (Release 3.0.3 #742 (comment))
  • Fix py3.6 compatibility for subprocess.run, see Improved versioning #738 (review)
This was referenced Nov 20, 2023
@matthijskooijman
Copy link
Member Author

Is data/hamster.db actually used? Does it define the initial db schema, or is it leftover from an old version?

Turns out it is, this bit of code copies the empty hamster.db into place when no database exists yet. So nothing to be done there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant