Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make experimental cell spaces work with PropertyLayer #2059

Open
quaquel opened this issue Feb 28, 2024 · 4 comments
Open

Make experimental cell spaces work with PropertyLayer #2059

quaquel opened this issue Feb 28, 2024 · 4 comments
Labels
experimental Release notes label feature Release notes label
Milestone

Comments

@quaquel
Copy link
Member

quaquel commented Feb 28, 2024

What's the problem this feature will solve?
PropertyGrid only works in conjunction with the established classes in space.py, but not yet with the new experiment cell spaces.

Describe the solution you'd like
Make PropertyGrid work with cell spaces.

@quaquel quaquel added the feature Release notes label label Feb 28, 2024
@EwoutH
Copy link
Member

EwoutH commented Feb 28, 2024

For reference, PropertyLayer was implemented in #1898. So the functionality of the PropertyGrid needs to be ported to the experimental cell space, so it works with PropertyLayers.

@EwoutH EwoutH added the experimental Release notes label label Feb 28, 2024
@EwoutH EwoutH added the Sprints! A task that might be good to tackle during sprints! label May 21, 2024
@quaquel
Copy link
Member Author

quaquel commented Oct 30, 2024

Support has been added in #2319

@quaquel quaquel closed this as completed Oct 30, 2024
@EwoutH EwoutH changed the title Make experimental cell spaces work with PropertyGrid Make experimental cell spaces work with PropertyLayer Oct 30, 2024
@EwoutH EwoutH removed the Sprints! A task that might be good to tackle during sprints! label Oct 30, 2024
@EwoutH EwoutH added this to the v3.1 milestone Oct 30, 2024
@EwoutH
Copy link
Member

EwoutH commented Oct 30, 2024

Partly yes, but only basic functions are in, and not yet the extensive multi-propertylayer handeling stuff that is in _PropertyGrid.

@EwoutH EwoutH reopened this Oct 30, 2024
@quaquel
Copy link
Member Author

quaquel commented Nov 1, 2024

I had a look at _PropertyGrid because of #2440. It relies on 3 methods/attributes of _Grid: width, height, and get_neighborhood. The first two are available in new style Grid; the third, however, is defined at the Cell. So addressing this issue for new style grids probably means moving get_neighborhood_mask into Cell, or, probably even better, its own mixin.

Part of the issue is that Cell is used in Network and VoronoiGrid and, at least for now, because of #2431, I would not be in favor of trying to make property layers work in those spaces.

This also reinforces the point made in #2440 of moving property layer stuff into its own namespace seems sensible.]

So my current idea is to have a HasPropertyLayers mixin that can be combined with Grid (and who knows what else in the future), and HasProperties mixing for Cell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Release notes label feature Release notes label
Projects
None yet
Development

No branches or pull requests

2 participants