Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov upload broken - needs token from someone with admin access #2363

Closed
Corvince opened this issue Oct 15, 2024 · 4 comments · Fixed by #2366
Closed

Codecov upload broken - needs token from someone with admin access #2363

Corvince opened this issue Oct 15, 2024 · 4 comments · Fixed by #2366

Comments

@Corvince
Copy link
Contributor

Describe the bug
Working on #2361 I now discovered that our latest commit uploaded to codecov is 2 months old. Regularly posting coverage reports stopped working in January

Expected behavior
Codecov reports should be uploaded by github actions everytime they are run

To Reproduce
Error: Codecov token not found. Please provide Codecov token with -t flag.
can be seen for every GA action under "codecov", for example
https://github.com/projectmesa/mesa/actions/runs/11346031665/job/31554205137?pr=2362

Additional context
Here are the required steps to add a codecov token to our CI
https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage#add-the-codecov-token-to-your-repo-or-your-org
This can only be done by someone with admin access to mesa.

@quaquel
Copy link
Member

quaquel commented Oct 15, 2024

Good point. I ran into this as well a few week ago and completely forgot about opening an issue about it.

@EwoutH
Copy link
Member

EwoutH commented Oct 15, 2024

Apparently I have acces to the tokens (here), so I added it to the repository secrets.

image

If I'm correct you can now access it in GitHub Actions with ${{ secrets.CODECOV_TOKEN }}.

@Corvince
Copy link
Contributor Author

Thanks for the quick response @EwoutH! It works (#2366)

@EwoutH
Copy link
Member

EwoutH commented Oct 15, 2024

Awesome, thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants