-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script to list unlabeled PR's since latest release #2047
Conversation
Performance benchmarks:
|
for more information, see https://pre-commit.ci
Seeing unlabeled merged PRs is as easy as this, right? Anything since december 2023 should be labeled. |
That's true. Is there a way to filter to cut off further the earliest date? But if a bulk of the checklist can be automated, it would be easier to read the info from the command line. |
Yes, see the docs. |
@rht do you mind closing this PR? I think using the GitHub URL is automated enough for now. |
As I said on #2047 (comment), once again, if almost everything in the checklist is automated, it is better off to use the CLI script. This PR is a first step in that direction. I usually don't draft the releases, but if you, @jackiekazil , and @tpike3 find the automation to be not worth it, you may close this PR. |
I will do a review |
I see the vision, and I think I understand the issue. I am going to repeat it back to make sure I am not misunderstanding. ... |
The steps are:
As you may notice, it is much simpler than #1917 (comment), because the generate release note step (without drafting a release) already has an API. |
Just to re-iterate, In my opinion, this script is unnecessary, since you can just go to https://github.com/projectmesa/mesa/pulls?q=is%3Apr+is%3Amerged+no%3Alabel+merged%3A%3E%3D2023-12-01 and see which PRs need a label yet. I also don't know yet how this helps with automation. However, if this is useful for others I'm not against merging this. |
I am going to merge based on the discuss. If we don't end up using this in the future we can remove it. |
This is an automation of step 1 in #1917 (comment). Step 2-6 shouldn't be automated, because step 5 is manual, and is tied to these steps. In order for step 2-6 to be fully automated, step 7 needs to happen first (which is doable, actually).
@EwoutH given that the file is now CONTRIBUTING.md instead of .rst, you may add the release checklist there.