-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mesa.flat namespace #2091
Conversation
Performance benchmarks:
|
Performance benchmarks:
|
Agreed, but I'm afraid this is a 3.0 ticked since it's breaking. |
2.3 is released, so we can start with 3.0 development work, including moving this PR forward! Maybe we should add a deprecation warning to 2.3.x though. |
Can this be merged ASAP? This is a straightforward PR. |
Can we add a deprecation message to the 2.3 branch? |
I don't think anyone has ever used this namespace. It's not documented, and was already voted out in the past. |
But adding a deprecation warning should be straightforward and is best practice. |
Needs to fix the CI tests ASAP. The deprecation warning is not going to be a part of this PR. See #2133, which fixes the tests. |
@rht I believe our CI is working again, could you rebase this PR? |
This doesn't seem to be used as often as the current simple namespace.
Check green, thanks for this PR and merging! |
This doesn't seem to be used as often as the current simple namespace.
This doesn't seem to be used as often as the current simple namespace.