Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass model.random to schedulers #2359

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 15, 2024

As pionted out in by @EwoutH, #2350 broke the tutorial. This is due to not updating the schedulers to pass model.random. This fixes that bug (and does a few minor updates to the tutorial).

The tutorial needs a complete update to remove schedulers and use (in my view) the new grid spaces. I am not going to do that in this PR.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +0.3% [-0.3%, +0.9%] 🔵 +0.1% [-0.0%, +0.3%]
BoltzmannWealth large 🔵 +0.7% [-0.6%, +1.9%] 🔵 +1.6% [+0.1%, +3.2%]
Schelling small 🔵 -0.1% [-0.7%, +0.5%] 🔵 +2.2% [+1.3%, +3.1%]
Schelling large 🔵 +0.6% [-1.5%, +2.4%] 🔵 +0.2% [-1.8%, +2.3%]
WolfSheep small 🔵 +1.5% [+1.1%, +1.9%] 🔵 +1.6% [+1.2%, +2.2%]
WolfSheep large 🔵 +0.2% [-0.6%, +1.0%] 🔵 +1.2% [-0.9%, +2.9%]
BoidFlockers small 🔵 +1.0% [+0.4%, +1.7%] 🔵 +0.9% [+0.4%, +1.4%]
BoidFlockers large 🔵 +1.0% [-0.4%, +2.0%] 🔵 +1.1% [+0.4%, +1.7%]

@EwoutH EwoutH added the bug Release notes label label Oct 15, 2024
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, changes to time.py look good. It's nice to give it a proper deprecation period this way.

Few comments about the files.

I am not going to do that in this PR.

So you say ;)

Luckily Tom is already on it!

docs/tutorials/agent_data.csv Outdated Show resolved Hide resolved
docs/tutorials/intro_tutorial.ipynb Outdated Show resolved Hide resolved
docs/tutorials/model_data.csv Outdated Show resolved Hide resolved
@EwoutH EwoutH removed their assignment Oct 15, 2024
This reverts commit cb06beb.
@quaquel
Copy link
Member Author

quaquel commented Oct 15, 2024

I reverted all notebook stuff to make @tpike3 life easier.

@quaquel quaquel requested a review from EwoutH October 15, 2024 09:30
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@EwoutH EwoutH changed the title Bug fix in schedulers fix: pass model.random to schedulers Oct 15, 2024
@EwoutH EwoutH merged commit 6fcd5b0 into projectmesa:main Oct 15, 2024
10 of 12 checks passed
@quaquel quaquel deleted the tutorial branch October 15, 2024 09:47
This was referenced Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants