Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test_time back #2367

Merged
merged 7 commits into from
Oct 16, 2024
Merged

add test_time back #2367

merged 7 commits into from
Oct 16, 2024

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 15, 2024

As evidenced by #2350 and #2359, its rather useful to keep testing this even though it is deprecated.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🟢 -4.8% [-6.1%, -3.5%] 🔵 -0.3% [-0.5%, -0.2%]
BoltzmannWealth large 🔵 -0.7% [-1.1%, -0.3%] 🟢 -8.3% [-8.6%, -7.9%]
Schelling small 🔵 -1.8% [-2.3%, -1.3%] 🔵 -0.6% [-0.9%, -0.4%]
Schelling large 🔵 -1.9% [-3.2%, -0.5%] 🟢 -7.9% [-9.8%, -5.8%]
WolfSheep small 🔵 +0.0% [-0.1%, +0.2%] 🔵 +0.3% [+0.1%, +0.5%]
WolfSheep large 🔵 -3.1% [-3.9%, -2.3%] 🟢 -6.7% [-8.7%, -4.3%]
BoidFlockers small 🔵 +1.9% [+1.3%, +2.5%] 🔵 +0.2% [-0.3%, +0.7%]
BoidFlockers large 🔵 +2.7% [+1.9%, +3.5%] 🔵 +0.8% [+0.2%, +1.3%]

@quaquel
Copy link
Member Author

quaquel commented Oct 15, 2024

I know why the tests are breaking, but I have run out of time now to fix them all. Will pick this up later today.

@quaquel
Copy link
Member Author

quaquel commented Oct 16, 2024

All unit tests are now fixed. This is ready to be merged

@quaquel quaquel requested a review from EwoutH October 16, 2024 19:11
Copy link
Contributor

@Corvince Corvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

@quaquel quaquel merged commit 447bf40 into projectmesa:main Oct 16, 2024
11 of 12 checks passed
@EwoutH
Copy link
Member

EwoutH commented Oct 16, 2024

Awesome, thanks!

@jackiekazil jackiekazil added the testing Release notes label label Oct 17, 2024
@quaquel quaquel deleted the test_time branch November 4, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants