Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to override overloads for standard library? #101

Open
LywLover opened this issue Feb 26, 2022 · 1 comment
Open

How to override overloads for standard library? #101

LywLover opened this issue Feb 26, 2022 · 1 comment

Comments

@LywLover
Copy link

Hello,
Is there a way to override overloads for standard library?
Below is part of my code which is not getting the expected result.

@NotNull private static final Overload OVERLOAD_MATCHES = Overload.binary(Overloads.MatchesString, (lhs, rhs) -> {
  System.out.println("---override matches---");
  String inst = (String) lhs.value();
  String target = (String) rhs.value();
  boolean result = target.matches(inst);
  return result ? BoolT.True : BoolT.False;
});

@Test public void testMatchs() {
  boolean result1 = XrayCEL.eval("'1234'.matches(r'\\d+')");
  System.out.println(result1); // output: true

  boolean result2 = XrayCEL.eval("r'\\d+'.matches('1234')");
  System.out.println(result2); // output: false
}

My override for matches is not be called, the log message are not be printed , it still used standard library's matches.

  • Standard -> string.matches(regexString)
  • Expected -> regexString.matches(string)
@snazy
Copy link
Member

snazy commented Mar 1, 2022

Nope. The r'string' syntax means raw string. CEL has no "regex type" or so.

So both .eval()s in your example are technically StringT.matches(StringT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants