Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust highlighting colors with treesitter appear to be wrong #256

Closed
koritar-aqg opened this issue May 19, 2023 · 4 comments
Closed

Rust highlighting colors with treesitter appear to be wrong #256

koritar-aqg opened this issue May 19, 2023 · 4 comments

Comments

@koritar-aqg
Copy link

koritar-aqg commented May 19, 2023

Hi, I installed this theme today and the colors on my Rust code seems pretty off of what it should look like.

This is how I installed and configured it using lazy.nvim:
image

Here's a screenshot of the theme on my neovim config:
image

And here's how it should look like based on github and vscode theme:
image

@AlexXi19
Copy link

AlexXi19 commented May 22, 2023

+1 on this. Colors are still a bit off 😞 . This is with github dark high contrast. Though the coloring seems a bit better compared to before the refactor.
Screenshot 2023-05-22 at 12 40 57 PM
Screenshot 2023-05-22 at 12 41 03 PM

@tmillr
Copy link
Member

tmillr commented Jun 18, 2023

Try updating the plugin. A bunch of changes were just merged in #259. It might not be perfect yet, but it should be a substantial improvement:

Dimmed

Screenshot 2023-06-18 at 3 52 34 AM

Dark

Screenshot 2023-06-18 at 3 56 37 AM

Light

Screenshot 2023-06-18 at 3 58 06 AM

Dark High Contrast

Screenshot 2023-06-18 at 4 01 41 AM

@koritar-aqg
Copy link
Author

koritar-aqg commented Jun 19, 2023

Just updated the plugin and tested it out, looks way better than before, there are some wrong colors here and there and as you said it's not perfect yet, but overall it's really good! Really appreciate your work!

@tmillr
Copy link
Member

tmillr commented Jul 3, 2023

Just updated the plugin and tested it out, looks way better than before, there are some wrong colors here and there and as you said it's not perfect yet, but overall it's really good! Really appreciate your work!

Awesome thank you! If there's anything specific left you'd like to report or want checked out, feel free to leave a comment on #252.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants